JSONAPI-Resources / JSONAPI-Resources/jsonapi-resources

Resource with caching enabled + sort + distinct filter breaks

Abierto
#1,272 4 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Lenguaje dominante
Ruby
Estrellas
2.3k
Forks
546
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

This issue is a (choose one):

tldr; You can't use distinct on a filter/recordset, plus a sort order, with caching enabled, when using postgres

  • Problem/bug report.
  • Feature request.
  • Request for support. Note: Please try to avoid submitting issues for support requests. Use Gitter instead.

Checklist before submitting:

  • I've searched for an existing issue.
  • I've asked my question on Gitter and have not received a satisfactory answer.
  • I've included a complete bug report template. This step helps us and allows us to see the bug without trying to reproduce the problem from your description. It helps you because you will frequently detect if it's a problem specific to your project.
  • The feature I'm asking for is compliant with the JSON:API spec.

Description

Choose one section below and delete the other:

Bug reports:

Setup:

  • Rails 5.2.3
  • Ruby 2.6.3
  • jsonapi-resources 0.9.5 (also tested in 0.10.x)
  • postgres 11.x
  • redis for caching

We have an index endpoint that's hitting a resource with caching enabled, using a query parameter similar to this:

?sort=name&filter[name]=john

I receive an error from postgres below:

E, [2019-07-26T13:46:14.916989 #62203] ERROR -- : Internal Server Error: PG::InvalidColumnReference: ERROR:  for SELECT DISTINCT, ORDER BY expressions must appear in select list
LINE 1: ...WHERE (lower(contacts.name) LIKE 'john') ORDER BY "contacts"...
  • A similar error occurs with Postgres (peeps-uuid fork example linked below)
  • This occurs in both 0.9.5 & 0.10.x
  • This doesn't happen with sqlite3. i know postgres & sqlite3 (and mysql) handle certain things differently, but I don't think this is so much a database issue as it is an issue with how cache-keys are calculated
    • I do get a different error with sqlite3 (wrong number of args w/ mget)
    • Using a memory store instead of redis makes this error go away too (haven't tested outside of this script however)
  • Removing caching, everything works fine (so the query itself is OK)

The root cause, I believe, is in this line because we're only plucking the ID & cached field, but we also need the name (because of the sort/order passed in)

Bug report template:

https://gist.github.com/jaydorsey/b6f290fa2f1b7a002b6e734033373ff7

Fork/branch of peeps-uuid showing the same issue with Postgres:

https://github.com/jaydorsey/peeps-uuids/pull/1

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Lee lib/jsonapi/resource.rb alrededor de la línea 1097 y luego revisa el gist del informe de errores enlazado y la reproducción de peeps-uuids. Confirma la corrección probando el filtro distinct con ordenación y caché de Redis contra PostgreSQL, preservando el comportamiento existente sin caché.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
postgresql, rails, redis, ruby
Área
backend, databases
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.