IntersectMBO / IntersectMBO/evolution-sdk

Declarative CBOR schema via annotations (CborId)

Abierto
#189 1 comentario 0 reacciones 0 asignados Ver en GitHub
enhancement
Lenguaje dominante
TypeScript
Estrellas
22
Forks
30
Merge medio
5 h 29 min
PR fusionados (30 d)
12

Descripción

## Summary

Replace hand-written `FromCDDL` transforms with declarative schema annotations that describe CBOR wire format directly on Effect Schema types.

## Motivation

Currently each module (TransactionBody, TransactionWitnessSet, Transaction, etc.) has:
- A `CDDLSchema` (intermediate CBOR AST type)
- A `FromCDDL` transform (hand-written 200-500 line encode/decode)
- A `FromCBORBytes` that composes `FromBytes` with `FromCDDL`

This creates a two-hop pipeline (`Uint8Array → CBOR AST → domain`) with a validation boundary that clones objects and strips Symbol metadata (e.g. `kEncoding` for encoding preservation).

## Proposal

A `CborId` Symbol annotation on Effect Schemas that carries CBOR layout metadata:

```ts
const CborId = Symbol.for("evolution/CborId")

const Address = Schema.Uint8ArrayFromSelf.annotations({
[CborId]: { tag: 259 }
})

const Value = Schema.Struct({
coin: Schema.BigIntFromSelf,
multiasset: Schema.optional(MultiAsset),
}).annotations({
[CborId]: { encoding: "array", fieldOrder: ["coin", "multiasset"] }
})

const TransactionOutput = Schema.Struct({
address: Address,
value: Value,
datum: Schema.optional(Datum),
scriptRef: Schema.optional(ScriptRef),
}).annotations({
[CborId]: { encoding: "map", keys: { address: 0n, value: 1n, datum: 2n, scriptRef: 3n } }
})
```

A generic CBOR codec engine reads `[CborId]` annotations to:
- Map struct fields to integer-keyed CBOR map entries or positional array slots
- Wrap values in CBOR tags (e.g. `#6.258` for sets)
- Handle optional fields (omit from map when undefined)
- Thread `kEncoding` preservation metadata automatically

## Benefits

- **Eliminates `FromCDDL`** — no hand-written encode/decode per module
- **Eliminates `CDDLSchema`** — domain schema IS the codec schema, no intermediate type
- **Encoding preservation is free** — single transform boundary, no clone/Symbol stripping
- **Self-documenting** — annotations describe the wire format directly
- **Less code** — TransactionBody goes from ~500 lines of transform to ~25 lines of annotated schema

## Scope

- Build `CborId` annotation types and codec engine in CBOR.ts (~200-400 lines)
- Convert all modules with FromCDDL transforms to use annotated schemas
- Handle edge cases: Tag-258 sets, redeemer map/array duality, nested maps, etc.
- Maintain backward compatibility with existing domain types

## Context

Discovered during CBOR encoding preservation work. The immediate fix (replacing `MapFromSelf`/`Tuple` CDDLSchemas with non-cloning `Schema.declare`) unblocks encoding preservation. This issue tracks the larger architectural improvement.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Empieza leyendo la implementación existente de CBOR.ts y las transformaciones FromCDDL en módulos como TransactionBody, TransactionWitnessSet y Transaction. Define allí las anotaciones CborId y el motor de codecs genérico, y después convierte los módulos afectados cubriendo los sets con tag-258, la dualidad entre mapa y array de redeemers, los mapas anidados, los campos opcionales y la compatibilidad hacia atrás.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
typescript
Área
backend-api-design
Tipo de issue
Refactorización
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
25/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.