InsightSoftwareConsortium / InsightSoftwareConsortium/ITKSphinxExamples

Enable JSPCD linting

Abierto
#237 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Jupyter Notebook
Estrellas
59
Forks
70
Merge medio
1 d 15 h
PR fusionados (30 d)
12

Descripción

Turn on `VALIDATE_JSCPD` in the [super-linter GitHub Action](https://github.com/github/super-linter) and address the issues it finds. Current output:

```
Run github/super-linter@v3
/usr/bin/docker run --name ghcriogithubsuperlinterv3145_502450 --label 5588e4 --workdir /github/workspace --rm -e pythonLocation -e VALIDATE_ALL_CODEBASE -e DEFAULT_BRANCH -e GITHUB_TOKEN -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_RETENTION_DAYS -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_SERVER_URL -e GITHUB_API_URL -e GITHUB_GRAPHQL_URL -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e GITHUB_ACTION_REPOSITORY -e GITHUB_ACTION_REF -e GITHUB_PATH -e GITHUB_ENV -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/ITKExamples/ITKExamples":"/github/workspace" ghcr.io/github/super-linter:v3.14.5
--------------------------------------------------------------------------------

/@@#///////@@/(@//@%/(@.@( @@
@@//////////////////////////////#* @@@
@////@//(///////////@@@@@///@//@/@**//@@(
@///////@///////////////@@@@ ( @,
@/(&/@//////////////////// @
@////////////////////////@@ @
@%////////(//////////%/////&@ @@ *,@ ______________
@@@@@/@/#/////(&////////////////// .@ / \
*@@@@@. .%///(//@//////////////////&. .@@, @% / Don't mind me \
@@% .&@&&/@.@//&/////(////////// @@@@@@@@@ .. &@ / I'm just looking \
@@% @@@@@ @&/////////////////# @/ V @@/ ,@@@ @ < for some trash... |
@@@% @@@@ .%@@@@//////#@ @ @@ @ .,. \__________________/
@@@/@( (@@@@% @/\ %
@@@@( . .@@/\ #
@ %@%

--------------------------------------------------------------------------------
2021-03-16 02:12:45 [INFO] ---------------------------------------------
2021-03-16 02:12:45 [INFO] --- GitHub Actions Multi Language Linter ----
2021-03-16 02:12:45 [INFO] - Image Creation Date:[2021-01-30T05:18:38Z]
2021-03-16 02:12:45 [INFO] - Image Revision:[93e067cf8298498f3eb01853db18839d933b0eee]
2021-03-16 02:12:45 [INFO] - Image Version:[93e067cf8298498f3eb01853db18839d933b0eee]
2021-03-16 02:12:45 [INFO] ---------------------------------------------
2021-03-16 02:12:45 [INFO] ---------------------------------------------
2021-03-16 02:12:45 [INFO] The Super-Linter source code can be found at:
2021-03-16 02:12:45 [INFO] - https://github.com/github/super-linter
2021-03-16 02:12:45 [INFO] ---------------------------------------------
2021-03-16 02:12:45 [INFO] --------------------------------------------
2021-03-16 02:12:45 [INFO] Gathering GitHub information...
2021-03-16 02:12:45 [INFO] Successfully found:[GITHUB_SHA], value:[74142c32611a912d72946fd8f543e14524b5c481]
2021-03-16 02:12:45 [INFO] Successfully found:[GITHUB_WORKSPACE], value:[/github/workspace]
2021-03-16 02:12:45 [INFO] Successfully found:[GITHUB_EVENT_PATH], value:[/github/workflow/event.json]
2021-03-16 02:12:45 [INFO] Successfully found:[GITHUB_ORG], value:[InsightSoftwareConsortium]
2021-03-16 02:12:45 [INFO] Successfully found:[GITHUB_REPO], value:[ITKExamples]
2021-03-16 02:12:45 [INFO] Successfully found:[GITHUB_TOKEN]
2021-03-16 02:12:45 [INFO] Successfully found:[GITHUB_REPOSITORY], value:[InsightSoftwareConsortium/ITKExamples]
2021-03-16 02:12:45 [INFO] Successfully found:[GITHUB_RUN_ID], value:[656102740]
2021-03-16 02:12:45 [INFO] --------------------------------------------
2021-03-16 02:12:45 [INFO] Gathering user validation information...
2021-03-16 02:12:45 [INFO] - Only validating [new], or [edited] files in code base...
You are not currently on a branch.
Please specify which branch you want to merge with.
See git-pull(1) for details.

git pull

2021-03-16 02:12:50 [INFO] ---------------------------------
2021-03-16 02:12:50 [INFO] ------ File list to check: ------
2021-03-16 02:12:50 [INFO] ---------------------------------
2021-03-16 02:12:50 [INFO] ----------------------------------------------
2021-03-16 02:12:50 [INFO] Successfully gathered list of files...
2021-03-16 02:12:51 [INFO]
2021-03-16 02:12:51 [INFO] ----------------------------------------------
2021-03-16 02:12:51 [INFO] ----------------------------------------------
2021-03-16 02:12:51 [INFO] Linting [JSCPD] files...
2021-03-16 02:12:51 [INFO] ----------------------------------------------
2021-03-16 02:12:51 [INFO] ----------------------------------------------
2021-03-16 02:12:51 [INFO] ---------------------------
2021-03-16 02:12:51 [INFO] File:[.github/workflows/build-test-publish.yml]
2021-03-16 02:12:52 [ERROR] Found errors in [jscpd] linter!
2021-03-16 02:12:52 [ERROR] Error code: 1. Command output:
------
Clone found (yaml):
- /github/workspace/.github/workflows/build-test-publish.yml [162:7 - 239:30] (77 lines, 156 tokens)
/github/workspace/.github/workflows/build-test-publish.yml [42:7 - 113:30]

Clone found (yaml):
- /github/workspace/.github/workflows/build-test-publish.yml [253:23 - 289:45] (36 lines, 218 tokens)
/github/workspace/.github/workflows/build-test-publish.yml [125:20 - 160:45]

Clone found (yaml):
- /github/workspace/.github/workflows/build-test-publish.yml [162:7 - 239:30] (77 lines, 156 tokens)
/github/workspace/.github/workflows/build-test-publish.yml [42:7 - 113:30]

162 │ 42 │ - name: Get specific version of CMake, Ninja
163 │ 43 │ uses: lukka/get-cmake@v3.18.3
164 │ 44 │
165 │ 45 │ - name: Download ITK
166 │ 46 │ run: |
167 │ 47 │ cd ..
168 │ 48 │ git clone https://github.com/InsightSoftwareConsortium/ITK.git
169 │ 49 │ cd ITK
170 │ 50 │ git checkout ${{ matrix.itk-git-tag }}
171 │ 51 │
172 │ 52 │ - name: Build ITK
173 │ 53 │ if: matrix.os != 'windows-2019'
174 │ 54 │ run: |
175 │ 55 │ cd ..
176 │ 56 │ mkdir ITK-build
177 │ 57 │ cd ITK-build
178 │ 58 │ cmake -DCMAKE_C_COMPILER:FILEPATH="${{ matrix.c-compiler }}" -DBUILD_SHARED_LIBS:BOOL=ON -DCMAKE_CXX_COMPILER="${{ matrix.cxx-compiler }}" -DCMAKE_BUILD_TYPE:STRING=${{ matrix.cmake-build-type }} -DBUILD_TESTING:BOOL=OFF -GNinja ../ITK
229 │ 109 │ set(dashboard_cache "
230 │ 110 │ ITK_DIR:PATH=\${CTEST_DASHBOARD_ROOT}/ITK-build
231 │ 111 │ BUILD_TESTING:BOOL=ON
232 │ 112 │ ITK_WRAP_PYTHON:BOOL=ON
233 │ 113 │ ")
234 │ 114 │ string(TIMESTAMP build_date "%Y-%m-%d")
235 │ 115 │ message("CDash Build Identifier: \${build_date} \${CTEST_BUILD_NAME}")
236 │ 116 │ message("CTEST_SITE = \${CTEST_SITE}")
237 │ 117 │ include(\${CTEST_SCRIPT_DIRECTORY}/itk_common.cmake)
238 │ 118 │ EOF
239 │ 119 │ cat dashboard.cmake

Clone found (yaml):
- /github/workspace/.github/workflows/build-test-publish.yml [253:23 - 289:45] (36 lines, 218 tokens)
/github/workspace/.github/workflows/build-test-publish.yml [125:20 - 160:45]

253 │ 125 │ :
254 │ 126 │ runs-on: ${{ matrix.os }}
255 │ 127 │ strategy:
256 │ 128 │ max-parallel: 3
257 │ 129 │ matrix:
258 │ 130 │ os: [ubuntu-18.04, windows-2019, macos-10.15]
259 │ 131 │ include:
260 │ 132 │ - os: ubuntu-18.04
261 │ 133 │ c-compiler: "gcc"
262 │ 134 │ cxx-compiler: "g++"
263 │ 135 │ itk-git-tag: "v5.2rc03"
264 │ 136 │ cmake-build-type: "MinSizeRel"
265 │ 137 │ - os: windows-2019
266 │ 138 │ c-compiler: "cl.exe"
267 │ 139 │ cxx-compiler: "cl.exe"
268 │ 140 │ itk-git-tag: "v5.2rc03"
269 │ 141 │ cmake-build-type: "Release"
270 │ 142 │ - os: macos-10.15
271 │ 143 │ c-compiler: "clang"
272 │ 144 │ cxx-compiler: "clang++"
273 │ 145 │ itk-git-tag: "v5.2rc03"
274 │ 146 │ cmake-build-type: "MinSizeRel"
275 │ 147 │
276 │ 148 │ steps:
277 │ 149 │ - uses: actions/checkout@v1
278 │ 150 │ - name: Set up Python 3.7
279 │ 151 │ uses: actions/setup-python@v1
280 │ 152 │ with:
281 │ 153 │ python-version: 3.7
282 │ 154 │
283 │ 155 │ - name: Install build dependencies
284 │ 156 │ run: |
285 │ 157 │ python -m pip install --upgrade pip
286 │ 158 │ python -m pip install ninja
287 │ 159 │ python -m pip install itk==5.2rc03
288 │ 160 │ python -m pip install matplotlib
289 │ 161 │ python -m pip install itkwidgets

Found 2 clones.
ERROR: jscpd found too many duplicates (26.53%) over threshold (0%)
Error: ERROR: jscpd found too many duplicates (26.53%) over threshold (0%)
at ThresholdReporter.report (/node_modules/@jscpd/finder/dist/reporters/threshold.js:12:19)
at /node_modules/@jscpd/finder/dist/in-files-detector.js:82:26
at Array.forEach ()
at /node_modules/@jscpd/finder/dist/in-files-detector.js:81:28
```

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.