InsightSoftwareConsortium / InsightSoftwareConsortium/ITKSphinxExamples

Inconsistent Output Baseline Comparisons

Abierto
#212 1 comentario 1 reacción 1 asignado Reclamado por @mseng10 Ver en GitHub
Lenguaje dominante
Jupyter Notebook
Estrellas
59
Forks
70
Merge medio
1 d 15 h
PR fusionados (30 d)
12

Descripción

## Description
After fixing a number of failing tests in the recent weeks, I came across some inconsistencies in the baseline test cases. Essentially, all of the baseline comparisons that compare an image without the name `OutputBaseline`, are incorrectly comparing results. An example can be found in the `AddNoiseToBinaryImageTestBaselineComparison`, which produces:
```
/Users/mseng_l/ITKExamples-build/bin/ImageCompareCommand "--test-image"
"/Users/mseng_l/ITKExamples-build/src/Core/Common/AddNoiseToBinaryImage/AddNoiseToBinaryImage.png" "--baseline-image"
"/Users/mseng_l/ITKExamples-build/src/Core/Common/AddNoiseToBinaryImage/AddNoiseToBinaryImage.png"
```
-------------

As shown above, the baseline comparison is not comparing the example's output to the baseline image, but rather the baseline image to itself, which will always yield a passing result.

This and many others will likely require one of the following changes:
- [ ] Remove baseline comparisons for examples that do not produce a consistent result (i.e. `AddNoiseToBinaryImage` due to `MersenneTwisterRandomVariateGenerator`)
- [ ] Rename baseline images to `OutputBaseline` for examples that consistently produce and save their output
- [ ] Implement `ImageFileWriter` for examples that do not save their output. Subsequently update the baseline comparison for that example, upload the image to `Girder` and finally update the `Documentation.rst`

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.