ImperialCollegeLondon / ImperialCollegeLondon/virtual_ecosystem

Soil hydrology constants are soil type dependent - create functions to calculate across grid

Open
#769 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
20
Forks
5
Avg merge
2d 1h
Merged PRs (30d)
34

Description

We noticed that some constants are shared across soil and hydrology model and we stored them in different places, this will be addressed with #768

In the longer term, we want these constants NOT to be floats but rather soil type dependent arrays. The hydrology model is already set up to take arrays, for example for soil moisture capacity.

We would like a function to calculate these constants based on input soil maps. This could be part of the `init` of the model, need to discuss where to best place it (core or hydrology or soil).

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the shared-constant work in #768 and the model's init path. Compare the core, hydrology, and soil areas to determine where soil-map inputs and soil-type-dependent arrays belong. Done means the constants are calculated from soil maps and supplied as arrays to the hydrology model, with the integration location agreed.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.