ImperialCollegeLondon / ImperialCollegeLondon/virtual_ecosystem
Rename `set_filled_canopy` to `set_active_canopy` and related
- Dominant language
- Python
- Stars
- 20
- Forks
- 5
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 34
Description
The vertical layer structure has a fixed number of canopy layers and we currently use the `LayerStructure.set_filled_canopy` method to set which layers are currently being used across any grid cells. Those layers aren't technically filled - the bottom one will very likely be partially filled. It would be better to rename the method to `set_active_canopy_layers` and then update all the indices and other names that refer to filled canopy.
@vgro - What do you think?
Contributor guide
Research direction
Search the repository for LayerStructure.set_filled_canopy and related filled-canopy names and indices, then read the surrounding layer-structure code to map all references. Rename the method to set_active_canopy_layers and update the related names consistently; done means no stale references remain and the existing checks still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100