ImperialCollegeLondon / ImperialCollegeLondon/virtual_ecosystem

Abiotic simple - conservation of energy with bounds setting

Open
#483 0 comments 0 reactions 1 assignee Claimed by @vgro View on GitHub
Dominant language
Python
Stars
20
Forks
5
Avg merge
2d 1h
Merged PRs (30d)
34

Description

At the moment, the `abiotic_simple` model sets values that fall outside the range of expected values to the upper or lower bound value. This is true for all updated variables; the bounds are defined in the `abiotic_simple/constants.py`. The problem is that this approach does not conserve energy or matter.

I currently do not have a solution ready. For now, we should produce a warning or error message.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.