ImperialCollegeLondon / ImperialCollegeLondon/virtual_ecosystem

Move `Grid` instance from `Data` into `CoreComponents`

Open
#376 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
20
Forks
5
Avg merge
2d 1h
Merged PRs (30d)
34

Description

**Is your feature request related to a problem? Please describe.**
It's a much more natural home for `Grid`, and can then be added cleanly to all models via the `BaseModel`. Passing `CoreComponents` and possibly `Config` to `Data` is then likely part of the plan for fixing old problems like #208.

**Describe the solution you'd like**
Add `Grid` to `CoreComponents` and populate `BaseModel.grid` as a core shared attribute, rather than it being oddly accessed through `Data`.

Contributor guide

Open the contributing guide

Research direction

Start by tracing how Grid is currently stored and accessed through Data, then inspect CoreComponents and BaseModel to understand their shared attributes. Done means Grid is added to CoreComponents, BaseModel.grid is populated as a core shared attribute, and access through Data is no longer required.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.