ImperialCollegeLondon / ImperialCollegeLondon/virtual_ecosystem
Make it clearer that the PFT definitions need to be complete
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 20
- Forks
- 5
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 34
Description
When running the latest GitHub release version, the following error occurs during initialization:
```
KeyError: "['c_mass_fruit_flesh', 'c_mass_per_fruit_seed', 'seeds_per_fruit'] not in index"
```
These vars were not provided as input data yet, but I assumed the VE would be able to use the default values instead when no input data is provided for these. I'll address these new input data vars soon, but this issue is to point out that the VE currently does not have access to the default values for these (and that this is currently blocking `ve_run`).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the initialization failure with the latest GitHub release and running ve_run using incomplete PFT input data. Inspect how the PFT definitions and default values are handled, then confirm the behavior when c_mass_fruit_flesh, c_mass_per_fruit_seed, and seeds_per_fruit are absent. Done means the expected requirement or default-value behavior is clear and the reported initialization error is addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100