ImperialCollegeLondon / ImperialCollegeLondon/virtual_ecosystem
Target per-file axis checking not per variable
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 20
- Forks
- 5
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 34
Description
At the moment, every variable is checked on loading to see if it has correct axis coordinates and dimensions. But, for variables from the same NetCDF file, we can validate the axes once because they will be the same.
There are a lot of variables and this was causing pretty bad behaviour. I think #1348 will fix the worst of it but removing the redundant checking will still be a sensible performance bump.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing where variables from NetCDF files are loaded and where axis coordinates and dimensions are validated. Compare the related behavior in #1348 and identify how validation can be shared for variables from the same file. Done means each file's axes are validated once while all variables still receive correct validation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- performance
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100