Imageomics / Imageomics/pyphenoscape

Improve term_details() return value

Open
#3 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Right now term_details() returns a dictionary. This data is the data sent back from the phenoscape KB API:
https://github.com/Imageomics/pyphenoscape/blob/af01032a221b3f54c87c8f112198339c6b64bde8/src/phenoscape/kb.py#L31
Consider making this an object.

See https://github.com/Imageomics/pyphenoscape/pull/2#pullrequestreview-1376422708

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/phenoscape/kb.py around line 31, where term_details() returns data from the Phenoscape KB API. Read pull request #2 and its linked review for the prior discussion. Done requires an agreed object representation that replaces the current dictionary return value.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.