Imageomics / Imageomics/dashboard-prototype

Filtering Questions

Open
#34 0 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
Python
Stars
6
Forks
2
PR merge metrics
No merged PRs in 30d

Description

> I'd note that applying a search or filter to data that returns no results is in general not in error, and arguably should result in an empty result set, not an exception. It seems the picture here is complicated by the fact that based on filtering alone the result set isn't empty, but becomes empty once we remove rows that don't reference a valid image? Then the question is, is it an error to have rows without image to begin with, or is it not.

> Regardless of the answer, I feel this doesn't need to be sorted out here. We're at the prototype stage, and now the function at least either returns a result of a consistent type, or it doesn't return a result (by raising an exception), which seems good enough. So perhaps open an issue with the above question to be considered down the road if and when there's a lot more continued development.

_Originally posted by @hlapp in https://github.com/Imageomics/dashboard-prototype/pull/33#pullrequestreview-1540235417_

Also noted in this review: Timing of filtering out "unknown" `Image_filename` and `file_url` values. It may be more efficient to filter these first with large data; however, do we wish to preserve (display) information about entries that may match user filters but be missing filename or path information?

Contributor guide

No contributing guide indexed for this repository

Research direction

No implementation file or test is named. Review the discussion from pull request #33, then clarify the intended behavior for empty filtered results and rows with unknown Image_filename or file_url values; the issue is done when that policy is decided and its expected behavior is captured.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-visualization
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.