Imageomics / Imageomics/cautious-robot

Handling and testing other algorithms

Open
#68 0 comments 1 reaction 1 assignee Claimed by @codedbyishika View on GitHub
Dominant language
Python
Stars
5
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Based on this comment:
https://github.com/Imageomics/cautious-robot/pull/60#discussion_r3537629085

We can add an integration test that covers the support for alternate checksum algorithms.

Currently, we say we can support algorithms supplied by hashlib, but that's not true for those that require a length parameter.

A proposal would be to list the algorithms in hashlib, and then just exclude those specialized algorithms that require a length parameter, and others that have optional length parameters are only supported at the default length.
([As called out in sum-buddy](https://github.com/Imageomics/sum-buddy/blob/15671df438da647a5bcfd64a84c9787c0f30bc23/src/sumbuddy/__main__.py#L96))

And validate that the user input is supported with `choices`, raising a specific error if an unsupported entry is passed.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.