Imageomics / Imageomics/bioclip

Error in `make_catalog_reproduce.py` script

Open Beginner friendly
#41 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
278
Forks
26
PR merge metrics
No merged PRs in 30d

Description

Hi,

It seems like there is an error in the following lines of the `make_catalog_reproduce.py` script:

https://github.com/Imageomics/bioclip/blob/c73811216eb63afcdb905d3d4283667c5c5bcd64/scripts/evobio10m/make_catalog_reproduce.py#L115-L126

There is first a check that the length of the `taxon_data` tuple is 2 but then it's unpacked to 3 values which doesn't make sense.

In practice there is indeed 3 values and the logger prints an error for every items in those two datasets.

Best,
Rémi

Contributor guide

No contributing guide indexed for this repository

Research direction

Open scripts/evobio10m/make_catalog_reproduce.py and inspect lines 115-126, starting with how taxon_data is produced and unpacked. Confirm the tuple shape for the two affected datasets, align the validation with that shape, and run the reproduction script to verify that the spurious logger errors no longer appear.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.