ISISNeutronMuon / ISISNeutronMuon/InstrumentScripts

SANS: Handle leading/trailing whitespace in sample position strings

Offen Anfängerfreundlich
#120 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Python
Sterne
4
Forks
8
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Users occasionally edit measurement scripts manually and enter sample position strings with leading or trailing whitespace, for example: " 1CB" or
"1CB ". This is easy to do inadvertently and is often intended for readability rather than representing a different sample position.

Currently, when a position string contains extra whitespace, it is not recognised as a valid sample position. The issue is only detected when the script attempts to move the sample changer. At that point, the command is silently ignored because the requested position is not found in the list of valid positions. The run continues, resulting in fewer samples being measured than expected.

This behaviour is particularly problematic for unattended, overnight measurements, where users may only discover later that part of the sample sequence was skipped.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Rechercherichtung

Trace the SANS sample-position validation and lookup entry point; the issue does not name a file or test. Reproduce the behavior with positions such as " 1CB" and "1CB ", then verify that surrounding whitespace no longer causes a requested position to be skipped and that the existing validation coverage passes.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
python
Bereich
tooling
Issue-Typ
Bug
Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Aktivitätsstatus
Ruhig
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
68/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.