ISISComputingGroup / ISISComputingGroup/IBEX

JULABO: enable xon flow control by default

Aperta
#8,705 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Good First Issue
Lingua principale
Nessun dato sulla lingua
Stelle
6
Fork
2
Merge medio
16h 40m
PR unite (30g)
2

Descrizione

A julabo may be in hardware or software flow control. If in software and the ioc does not know then yo see `<13>` and `<11>` (Ctrl-S / Ctrl-Q) characters being sent from the julabo and causing the ioc to parse error. I believe it wouldbe safe to just enable xon by default. In asyn

ixon controls XON/OFF flow control on output. If the IOC receives an XOFF character, it suspends output until an XON character is received.

ixoff controls XON/OFF flow control on input. The IOC sends XOFF and XON characters as necessary to prevent input from coming in faster than programs are reading it. The external device sending the input data must respond to an XOFF character by suspending transmission, and to an XON character by resuming transmission.

So if we just enable `ixon` but not `ixoff` it should respond to the characters if sent from the julabo, but never send them to the julabo. There is a minor chance some data corruption might accidentally get interpreted as an `xoff`, do we think that is an issue? Serial parameters use `even` parity so there is some basic error checking.

For reference see

https://github.com/ISISComputingGroup/IBEX/issues/3865
https://github.com/ISISComputingGroup/IBEX/issues/3971

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Direzione di ricerca

Start by examining the asyn serial configuration and the behavior described in the linked IBEX issues 3865 and 3971. Done means XON input handling is enabled by default for JULABO communication while XOFF transmission remains disabled, without introducing parse errors from control characters.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Ambito
embedded-iot
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.