ISISComputingGroup / ISISComputingGroup/IBEX

JULABO: enable xon flow control by default

Open
#8,705 0 comments 0 reactions 0 assignees View on GitHub
Good First Issue
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

A julabo may be in hardware or software flow control. If in software and the ioc does not know then yo see `<13>` and `<11>` (Ctrl-S / Ctrl-Q) characters being sent from the julabo and causing the ioc to parse error. I believe it wouldbe safe to just enable xon by default. In asyn

ixon controls XON/OFF flow control on output. If the IOC receives an XOFF character, it suspends output until an XON character is received.

ixoff controls XON/OFF flow control on input. The IOC sends XOFF and XON characters as necessary to prevent input from coming in faster than programs are reading it. The external device sending the input data must respond to an XOFF character by suspending transmission, and to an XON character by resuming transmission.

So if we just enable `ixon` but not `ixoff` it should respond to the characters if sent from the julabo, but never send them to the julabo. There is a minor chance some data corruption might accidentally get interpreted as an `xoff`, do we think that is an issue? Serial parameters use `even` parity so there is some basic error checking.

For reference see

https://github.com/ISISComputingGroup/IBEX/issues/3865
https://github.com/ISISComputingGroup/IBEX/issues/3971

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.