ISISComputingGroup / ISISComputingGroup/IBEX

Danfysiks: remove commands on ioc start

Aperta
#4,359 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Nessun dato sulla lingua
Stelle
6
Fork
2
Merge medio
16h 40m
PR unite (30g)
2

Descrizione

As a developer I would like to implement decision 11 (from https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Decision-Log ) on Danfysiks.

The decision noted above says:

> Setting a device to remote mode should not be done on IOC start. There should be a clear indication on the OPI that it is in remote mode (where possible) and a button to set it into remote mode. There should also be an alarm on the PV but not at IOC level when the device is in local mode. It was thought that instrument scientists did not know that IOCs were restarting (e.g. when the updated a config for collimator) and so would be surprised at the change in the device.

Danfysiks currently send REM/UNLOCK commands at startup. I believe this may have caused point 1 of https://github.com/ISISComputingGroup/IBEX/issues/4355 , but I no longer have access to a real danfysik to test this theory.

Acceptance criteria:
- Removing the REM/UNLOCK commands is tested on one or more real danfysiks and confirmed (or not) as the cause of power supplies going to zero on IOC restart
- If the REM/UNLOCK commands were the cause, they are removed in favour of a manual button on the opi to reset the comms to remote mode
- There are indications/alarms on appropriate PVs if the power supply is not in remote mode

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Direzione di ricerca

Start with the Decision Log entry and the Danfysik IOC startup handling described in the issue, then identify the related OPI controls and PVs. Test on one or more real Danfysik power supplies; completion requires confirming the restart behavior, providing a manual remote-mode control if needed, and adding the specified indications or alarms.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Ambito
embedded-iot
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.