ISISComputingGroup / ISISComputingGroup/IBEX

Danfysiks: remove commands on ioc start

Open
#4,359 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

As a developer I would like to implement decision 11 (from https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Decision-Log ) on Danfysiks.

The decision noted above says:

> Setting a device to remote mode should not be done on IOC start. There should be a clear indication on the OPI that it is in remote mode (where possible) and a button to set it into remote mode. There should also be an alarm on the PV but not at IOC level when the device is in local mode. It was thought that instrument scientists did not know that IOCs were restarting (e.g. when the updated a config for collimator) and so would be surprised at the change in the device.

Danfysiks currently send REM/UNLOCK commands at startup. I believe this may have caused point 1 of https://github.com/ISISComputingGroup/IBEX/issues/4355 , but I no longer have access to a real danfysik to test this theory.

Acceptance criteria:
- Removing the REM/UNLOCK commands is tested on one or more real danfysiks and confirmed (or not) as the cause of power supplies going to zero on IOC restart
- If the REM/UNLOCK commands were the cause, they are removed in favour of a manual button on the opi to reset the comms to remote mode
- There are indications/alarms on appropriate PVs if the power supply is not in remote mode

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.