IMRCLab / IMRCLab/motion_capture_tracking

Redundant test dependencies in package.xml of motion_capture_tracking

Open
#26 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
83
Forks
44
PR merge metrics
No merged PRs in 30d

Description

Hello, after building and testing this project with branch develop, I found something unexpected.

I noticed the `package.xml` files in the package `motion_capture_tracking` contains the following content which means a format check.
```
ament_lint_auto
ament_lint_common
```
But the test section in `CMakeLists.txt` is commented out resulting in no testing programs to run actually.

So I think if we want the ament_lint tools to do a format check, maybe need add the testing section in the `CMakeLists.txt`.

If we do not need the ament_lint_tools, the test_depend might be a redundant dependency that could be removed to reduce the burden of project maintenance.

I would appreciate it if you could tell me how do you think of this?

Thanks!

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect the package.xml files for motion_capture_tracking and the commented test section in CMakeLists.txt. Determine whether ament lint checks are intended to run; done means either enabling the documented checks or removing the redundant test dependencies, with the package configuration and build remaining consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system, robotics
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.