ILXL / ILXL/cppaudit

Use FAIL instead of internal macro

Open
#12 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

https://github.com/ILXL/cpp-code-analyzer/blob/c627448b9d329bae4aa2972dc477bc2767f171cc/src/test/gtest_ext.h#L156

Can we replace this with FAIL() instead?

FAIL() << " timed out (> " #secs
" seconds). Check code for infinite loops"; \

This will use an exposed macro rather than something that is used internally by google test

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open src/test/gtest_ext.h at line 156 and inspect the timeout message macro. Replace the internal Google Test macro with the exposed FAIL() form shown in the issue, then run the relevant test suite to confirm timeout failures still report the expected message.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.