IEEE-RVCE / IEEE-RVCE/IEEE-RVCE.github.io
Documentation and code improvement
还没有人认领这个 Issue。
- 主要语言
- JavaScript
- 星标
- 3
- 派生
- 2
- PR 合并指标
- 30 天内没有已合并 PR
描述
Aim
This is an umbrella issue that has the following objectives
- Show the methods of documentation
- Track documentation progress
Progress
- Remove props for components that don't need it
- Convert the
.then()promise hell into readableasync-awaitexpressions - Add in-code documentation
Information
.then() Improvements
axios.put(hostname + '/api/gallery/' + props.data.iid, values, {
headers: {
'Content-Type': 'application/json',
Authorization: 'Bearer ' + localStorage.getItem('atoken')
},
})
.then((response) => {
if(response.data.ok === true)
setMeta({...meta, success: true})
else
setMeta({...meta, error: true})
})
.then(() => {
window.location.reload()
})
.catch((error) => {
console.error(error.response.data.status)
setMeta({...meta, error: true})
})
This piece of code can save different ways of fixing
Route 1 - Lesser .then calls
.then is not always required, except for working on a promise. Only axios here returns a promise, so it can be merged.
axios.put(hostname + '/api/gallery/' + props.data.iid, values, {
headers: {
'Content-Type': 'application/json',
Authorization: 'Bearer ' + localStorage.getItem('atoken')
},
})
.then((response) => {
if(response.data.ok === true)
setMeta({...meta, success: true})
else
setMeta({...meta, error: true})
window.location.reload()
})
.catch((error) => {
console.error(error.response.data.status)
setMeta({...meta, error: true})
})
Route 2 - Use Async await
Consider this alternate syntax:
try{
const response = await axios.put(hostname + '/api/gallery/' + props.data.iid, values, {
headers: {
'Content-Type': 'application/json',
Authorization: 'Bearer ' + localStorage.getItem('atoken')
},
});
if(response.data.ok === true)
setMeta({...meta, success: true})
else
setMeta({...meta, error: true})
window.location.reload()
}catch(error){
console.error(error.response.data.status)
setMeta({...meta, error: true})
}
Refer to
- (MDN)[https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/async_function]
- (Scotch)[https://scotch.io/tutorials/asynchronous-javascript-using-async-await]
JSDoc
Problem
export const component1 = (props) => {
//...
}
This component is difficult to pull out without referencing a parent component who used it.
Additionally, VSCode cannot provide autocomplete for props.
Solution
Use the JSDOC standard.
/**
* This component does x y z
* @param {{data:number[],data2:string}} props
*/
export const component1 = (props) => {
//...
}
This should explain the reason for the page and what its arguments are.
The added advantage is that VSCode (and GitHub's Markdown, if you can notice) has JSDoc integration, and can read this and provide autocomplete.
Please refer https://jsdoc.app/about-getting-started.html
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
首先定位 checklist 涵盖的 frontend 组件,并查看提供的 promise 和 JSDoc 示例。完成的标准是移除不必要的 props、改进已识别的 promise 链,并为相关组件添加描述其用途和参数的代码内文档。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- javascript
- 领域
- documentation, frontend
- Issue 类型
- 重构
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 需要澄清
- 新手友好度
- 30/100