HelloZeroNet / HelloZeroNet/ZeroNet

`optionalFileInfo` returns incorrect `is_downloaded` value

Aperta
#2,728 0 commenti 1 reazione 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
18.8k
Fork
2.3k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

* ZeroNet version: 0.7.2 (rev4555)

### Step 2: Describe the problem:

https://zeronet.io/docs/site_development/zeroframe_api_reference/#optionalfileinfo

According to the documentation this field has the following semantics:

```
is_downloaded | Whether this file has been completely downloaded
```

However its value is being returned as "1" for files that have never been downloaded.

#### Steps to reproduce:

The issue appears to be a collision in the `hashfield`.

https://github.com/HelloZeroNet/ZeroNet/blob/9d1bed11af8cf92951dd0f335e95101d8b1fa6a4/plugins/OptionalManager/ContentDbPlugin.py#L162-L164

So to reproduce you just need to receive new optional file with a `hash_id` that will collide with another hash in the site's hashfield.

#### Expected Results:

`is_downloaded` should return "1" only if the file has _actually_ been downloaded and "0" otherwise.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.