HelloZeroNet / HelloZeroNet/ZeroNet

Toggling "Open web browser on ZeroNet startup" twice doesn't restore old browser

Ouverte
#2,162 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
JavaScript
Étoiles
18.8k
Forks
2.3k
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

### Step 1: Please describe your environment

* ZeroNet version: v0.7.0, rev4172
* Operating system: reproducible on all
* Web browser: doesn't matter
* Tor status: doesn't matter
* Opened port: doesn't matter
* Special configuration: none

### Step 2: Describe the problem:

Quote from UiConfig.coffee:

```coffee
if key == "open_browser"
if value
value = "default_browser"
else
value = "False"
```

This means that once you click the checkbox (even accidentally) and you've manually set a browser (which might have a long path with CLI options), there's no easy way to restore it.

This also leads to a fact that toggling the checkbox twice doesn't remove the "1 configuration item value changed" banner, while toggling any other checkbox twice *does* remove it. This leads to confusion.

#### Steps to reproduce:

1. Setup a non-standard browser path in zeronet.conf (even `open_browser = chrome` will work)
2. Open UI Config
3. Toggle "Open web browser on ZeroNet startup" checkbox
4. Toggle "Open web browser on ZeroNet startup" checkbox
5. Press "Save settings"
6. Reboot ZeroNet

#### Observed Results:

`chrome` is replaced with `default_browser`

#### Expected Results:

`chrome` is not changed

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.