HelloZeroNet / HelloZeroNet/ZeroNet

Wrapper commands do not support positional arguments

Open
#1,792 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
18.8k
Forks
2.3k
PR merge metrics
No merged PRs in 30d

Description

Step 1: Please describe your environment
  • ZeroNet version: d3bf001752b5df11ebca5ef60f3974599d5c38bf
Step 2: Describe the problem:

Setting the title via:

ZeroFrame.cmd('wrapperSetTitle', 'My Great Title');

works fine, but takes in a string as input. Whereas you would also expect the following to work:

ZeroFrame.cmd('wrapperSetTitle', {title: 'My Great Title'});

But not so, as the title is set to [object Object].

Presumably every ZeroFrame command should handle the object syntax, including wrapperSetTitle?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start from the ZeroFrame.cmd entry point and the wrapperSetTitle command mentioned in the report, then trace how string and object arguments are handled. Confirm the expected argument form and verify that passing {title: 'My Great Title'} sets the title without producing [object Object].

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.