HelloZeroNet / HelloZeroNet/ZeroNet
Leaves UPnP forward when stopped
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 18.8k
- Forks
- 2.3k
- PR merge metrics
- No merged PRs in 30d
Description
How to reproduce:
- start with
--tor disable - stop gracefully with SIGINT
- observe that the router still has UPnP port forwarded:
ZeroNet | Yes | 15441 | 15441 | 192.168.1.10 | TCP
It should delete UPnP forwards when stopped gracefully.
As a good example, BitMessage handles UPnP very well: https://github.com/Bitmessage/PyBitmessage
I believe they have their own UPnP python implementation.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by starting with --tor disable, stopping with SIGINT, and checking the router's UPnP forwarding table. Trace the graceful shutdown path and UPnP forwarding behavior, using the linked BitMessage implementation as a reference; done means the ZeroNet forward is removed when stopping gracefully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100