GraphiteEditor / GraphiteEditor/Graphite

Canvas doesn't rerender on moving left by text field

Abierto
#4,393 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Rust
Estrellas
27.2k
Forks
1.3k
Merge medio
20 h 5 min
PR fusionados (30 d)
57

Descripción

## Description

When inserting a text field, and on updating it's content, the text field occasionally moves left if its length is more and doesn't fit the currently displayed canvas, it is done so as to accommodate the cursor to see what is currently being written. In doing so, it doesn't re render the underlying canvas on the right, rather shows the grey background. Reported first on [discord](https://discordapp.com/channels/731730685944922173/881073965047636018/1467105234500194314).

## Reproduce the issue

1. Open a new document
2. Select "Text Tool (T)".
3. Start writing something near the left side in a zoomed artboard and you should see the issue.

## Possible Culprits & Solution

When moving the canvas to fit the text, the frontend doesn't call a Send Layout/Redraw request which is generally sent when moving the canvas with scrollbars or mouse (observed via the debug messages). So, possible solution would be to trigger a redraw/Layout change request when length exceeds the current length and text begins to move to the left.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Línea de trabajo

Start with the Text Tool (T) flow and the canvas behavior when a text field grows beyond the visible artboard and shifts left. Use the debug messages to compare this automatic movement with scrollbar or mouse movement, especially whether a Send Layout/Redraw request is emitted. Done means the underlying canvas is redrawn instead of showing the grey background.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
rust
Área
computer-graphics, frontend
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Tranquilo
Claridad
Bastante claro
Aptitud para principiantes
58/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.