GraphiteEditor / GraphiteEditor/Graphite

Type hint is selected in node graph view

Offen Anfängerfreundlich
#4,311 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Rust
Sterne
27.2k
Forks
1.3k
Ø Merge
20 Std. 5 Min.
Gemergte PRs (30 T.)
57

Beschreibung

## Reproduction
- Drag a wire from an output with a resolved type
- Type something to narrow down your search
- Note how the type information is lost from the search since it is automatically selected

This is really annoying UX.

## The node catalogue is only temporary

Is it really? It is basically unchanged from its initial implementation for 2 years. See #2072.

## Code
The node catalogue automatically focuses the input (this is desired):
https://github.com/GraphiteEditor/Graphite/blob/9f9899cfd0c2ddea4a8664358b6b1834f30adc66/frontend/src/components/floating-menus/NodeCatalog.svelte#L110-L111
When the focus is changed, the text input automatically selects all the text (not desired)
https://github.com/GraphiteEditor/Graphite/blob/9f9899cfd0c2ddea4a8664358b6b1834f30adc66/frontend/src/components/widgets/inputs/TextInput.svelte#L31-L35

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Rechercherichtung

Start with frontend/src/components/floating-menus/NodeCatalog.svelte around lines 110-111 and frontend/src/components/widgets/inputs/TextInput.svelte around lines 31-35. Reproduce the node catalogue search after dragging a typed wire, then trace the focus change and text selection behavior. Done means the input still receives focus while the resolved type is not automatically selected, so typing narrows the search normally.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
javascript
Bereich
frontend
Issue-Typ
Bug
Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Aktivitätsstatus
Ruhig
Klarheit
Klar beschrieben
Anfängerfreundlichkeit
76/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.