GraphiteEditor / GraphiteEditor/Graphite

Make the Rasterize node resolution-aware

Abierto
#3,391 0 comentarios 0 reacciones 1 asignado Reclamado por @TrueDoctor Ver en GitHub
Graphics
Lenguaje dominante
Rust
Estrellas
27.2k
Forks
1.3k
Merge medio
20 h 5 min
PR fusionados (30 d)
57

Descripción

The current Rasterize node is a major footgun because its bounds have to be set manually, which multiple users have complained about feeling broken because they didn't realize a width, height, and X/Y offset had to be chosen to make use of the node.

We want to instead use the minimum of the content bounds and the viewport bounds (the context's footprint), and with a resolution assigned by the viewport resolution from the context's footprint. This lets us eliminate the bounds parameter of the Rasterize node so that node works without needing any parameters.

This makes the "Blend" node no longer necessary, because that is simply equivalent to a stack of two raster layers that feed into a Rasterize node. So that node can also be removed.

To allow the user to choose rendering bounds, we also need a separate Crop node. A user would apply a Rasterize node followed by a Crop node to achieve the same outcome. Perhaps also a Resample node to change the rendering resolution for upsampling/downsampling.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.