GraphiteEditor / GraphiteEditor/Graphite

Avoid needing the TaggedValue enum

Offen
#3,131 0 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @TrueDoctor Auf GitHub ansehen
Architecture
Vorherrschende Sprache
Rust
Sterne
27.2k
Forks
1.3k
Ø Merge
20 Std. 5 Min.
Gemergte PRs (30 T.)
57

Beschreibung

Discussion here: https://discord.com/channels/731730685944922173/860830913390575646/1412529955841245345 where @TrueDoctor wrote:

> We would need a self describing serialization format which does store the type information but if we want arbitrary compound types to work we will always have to do some form of manual deserializaiton
>
> something like this: https://github.com/dtolnay/typetag
>
> … this crates uses a similar link time hack to generate a list of all possible implementations for deserialization as we use for our node definitions
>
> So it should be possible to remove tagged values (or we could at least experiment with that), it's just a question of if that is useful to us rn and if we should prioritize this. And I don't think we should do that since tagged values work just fine for us rn

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.