GraphiteEditor / GraphiteEditor/Graphite
Dragging layers sharing a transform node applies multiple translations
- Vorherrschende Sprache
- Rust
- Sterne
- 27.2k
- Forks
- 1.3k
- Ø Merge
- 20 Std. 5 Min.
- Gemergte PRs (30 T.)
- 57
Beschreibung
Still a problem as of Jan 30, 2025. This happens with dragging but not G of the G/R/S feature, which is a good hint about how to begin solving it in the same manner.
---
Create a document containing two rectangles. Enter the node graph and add a layer node, using the data from the stroke node of one of the rectangles. Select all of the rectangles and drag them using the select tool. Observe how the translation is applied several times. When you drag around several layers we apply a transformation to the first transform node found for each layer; however because there are several layers sharing the same transform node, the translation is applied several times.
This also applies when dragging the top/left corners of an artboard with the Artboard tool (as was implemented in #2150).
Solutions:
- In select_tool.rs, instead of applying a delta to the current transform, store the transform at the start of the drag and compute the new transform based on that (similar to how dragging the selection bounds works)
- In graph_operation_message_handler.rs, check for cases where the node is used by several other nodes, and if that is the case then create a new transform node for each layer separately before applying the operation.
https://github.com/GraphiteEditor/Graphite/assets/78500760/8011ef59-a055-4e29-87a8-9df5d73351e6
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Rechercherichtung
Beginne in select_tool.rs und vergleiche das Ziehen mit der G/R/S-Implementierung. Untersuche anschließend graph_operation_message_handler.rs auf gemeinsam genutzte Transformationsknoten. Reproduziere das Node-Graph-Szenario mit zwei Rechtecken und das Ziehen an einer Ecke mit dem Artboard-Tool; fertig ist es, wenn jede Ebene genau einmal verschoben wird, selbst wenn Ebenen einen Transformationsknoten gemeinsam nutzen.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- rust
- Bereich
- computer-graphics
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Klar beschrieben
- Anfängerfreundlichkeit
- 55/100