GoogleCloudPlatform / GoogleCloudPlatform/ruby-docs-samples

Revisit bundler usage in E2E tests

未关闭
#751 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
samples type: feature request
主要语言
Ruby
星标
235
派生
210
PR 合并指标
30 天内没有已合并 PR

描述

Currently, App Engine, Cloud Run, and (I think) EventArc tests are classifed as E2E because they require access to gcloud. However, these tests aren't one-size-fits-all, and there are some issues. In particular, the test scripts all run bundler in the sample directory. This doesn't apply to some of the samples. For example, in the Cloud Run samples, the Gemfile is intended to be for the container being built and deployed to Cloud Run, not for the testing environment. As a result, for example, we are currently not able to install a newer version of Ruby (or bundler) in the deployment image because it has to match the versions used by the test harness. The test scripts should not assume that they must always run bundler in the sample directory.

The goal should be to allow bundler and Ruby to be updated in those samples (See #748)

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。