GoogleCloudPlatform / GoogleCloudPlatform/ruby-docs-samples

kokoro: not all tests being run

Offen
#1,527 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
samples
Vorherrschende Sprache
Ruby
Sterne
235
Forks
210
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Debugging #1525, I discovered that the tests being based on the logic in [.toys/kokoro-ci.rb](https://github.com/GoogleCloudPlatform/ruby-docs-samples/blob/main/.toys/kokoro-ci.rb#L140) may only include Gemfiles one and two levels deep.

This means that there are a number of tests in deeper nested directories that aren't being run.

My debugging in changing the `Gemfile` glob to `Dir.glob("*/**/Gemfile").each` (ignoring the top level Gemfile) gives more tests to execute (but also more failures).

Internal details b/392885740#comment6

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start by reading .toys/kokoro-ci.rb around line 140 and trace how Gemfiles are discovered and passed to the test runner. Compare the current glob with the proposed recursive glob, then run the relevant Kokoro test command. Done means deeper nested Gemfiles are included without unintentionally selecting the top-level Gemfile.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
ruby
Bereich
ci-cd
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
45/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.