GoogleCloudPlatform / GoogleCloudPlatform/ruby-docs-samples

kokoro: not all tests being run

Open
#1,527 0 comments 0 reactions 0 assignees View on GitHub
samples
Dominant language
Ruby
Stars
235
Forks
210
PR merge metrics
No merged PRs in 30d

Description

Debugging #1525, I discovered that the tests being based on the logic in [.toys/kokoro-ci.rb](https://github.com/GoogleCloudPlatform/ruby-docs-samples/blob/main/.toys/kokoro-ci.rb#L140) may only include Gemfiles one and two levels deep.

This means that there are a number of tests in deeper nested directories that aren't being run.

My debugging in changing the `Gemfile` glob to `Dir.glob("*/**/Gemfile").each` (ignoring the top level Gemfile) gives more tests to execute (but also more failures).

Internal details b/392885740#comment6

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.