GoogleCloudPlatform / GoogleCloudPlatform/nodejs-docs-samples

Running GitHub Workflows duplicate events: push and pull_request

Aperta
#2,891 0 commenti 0 reazioni 2 assegnatari Rivendicata da @sofisl Vedi su GitHub
priority: p2 samples type: cleanup
Lingua principale
JavaScript
Stelle
3k
Fork
2k
Merge medio
2g 19h
PR unite (30g)
44

Descrizione

The GitHub Workflow template runs for each set of samples on `push` and `pull_request`.

Based on my reading of the [syntax documentation](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions), pull_request is necessary for forks.

It looks like folks contributing from a branch in the repository would trigger duplicate tests. Looking at [some data](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/actions/workflows/ai-platform-snippets.yaml?query=event%3Apush), I don't see signs of duplicate work but documented points like https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#using-multiple-events indicate that there should be.

Action Items from this issue should be one of:
- Removing `push` as an event trigger from each config and the template
- Adding an in-line comment to each config and the template explaining why we use both

@sofisl could you provide some insight into why we have both triggering events in the config?

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.