GoogleCloudPlatform / GoogleCloudPlatform/java-docs-samples

security-command-center: samples contain many Spotbugs errors

Open
#9,546 0 comments 0 reactions 1 assignee Assigned to @vijaykanthm View on GitHub
priority: p2 samples triage me type: bug
Dominant language
Java
Stars
1.9k
Forks
2.9k
Avg merge
3d 3h
Merged PRs (30d)
17

Description

## In which file did you encounter the issue?

https://github.com/GoogleCloudPlatform/java-docs-samples/tree/main/security-command-center/snippets

## Did you change the file? If so, how?

no

## Describe the issue

[`SAMPLE_FORMAT.md`](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md) says the following:

> To run the Checkstyle, ErrorProne and SpotBugs plugins on an existing sample, run
>
> ```
> mvn clean verify -DskipTests -P lint
> ```

However, when I run that command in the `security-command-center/snippets` directory, it fails with 67 "bugs" (errors, really). I expected everything to pass at `HEAD`.

I didn't check any other directories, so this issue might exist elsewhere.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.