GoogleCloudPlatform / GoogleCloudPlatform/functions-framework-php

Bad publishTime format used when publishTime not provided in the message context

Ouverte
#167 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
bug P3
Langage dominant
PHP
Étoiles
213
Forks
37
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Current format:
```php
gmdate('%Y-%m-%dT%H:%M:%S.%6NZ')
```
That produces, for example, this string `%2023-%09-%29GMT%13:%Sep:%th.%650` instead of the [RFC 3339](https://tools.ietf.org/html/rfc3339) format.

It's an easy fix; I'll send a Pull Request. This might also be relevant for https://github.com/GoogleCloudPlatform/functions-framework-php/issues/66

---

I came across this when testing my cloud function with the PubSub emulator. There was a similar issue in the node implementation: https://github.com/googleapis/google-cloud-node/issues/1925.

Ultimately, it would be great if the emulator included this property. Is there a right place to file an issue with the PubSub emulator?
I assume that this is beyond the scope of this PHP repo, nonetheless, from my tests, it seems like there are situations where the `publishTime` is present in the PubSub message (for example when I'm pulling the message via the PubSub API), but not present when the payload reaches the cloud functions framework.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.