GoogleCloudPlatform / GoogleCloudPlatform/cloud-trace-data-source-plugin
Proposition to not format Trace SpanID
- Langage dominant
- Go
- Étoiles
- 16
- Forks
- 6
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
When using the plugin, I have noticed that SpanIDs are formatted.
```
spanIDField.Append(strconv.FormatUint(s.GetSpanId(), 10))
```
https://github.com/GoogleCloudPlatform/cloud-trace-data-source-plugin/blob/2926fd2d77f30b927663605524ef788d0d014eef/pkg/plugin/plugin.go#L297C3-L297C14
Problem is that makes the Span IDs "unusable":
Say you want to use this ID to check the logs for specific SpanId. Google Cloud Logging expects the spanID in '016x' format, as it is originally set in the Trace span metadata.
I would like to propose that the plugin wouldn't format the spanIDs.
I have tried to format the ID back to '016x' using Grafana variables and Big Query
```
DECLARE spanIDString STRING;
SET spanIDString = "$span_id";
SELECT FORMAT("%016x", CAST(spanIDString AS INT64)) AS spanID;
```
but there are times where the spanID is getting (from the plugin) a value too large to be cast as an INT64. So my workaround doesn't work either.
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Start with pkg/plugin/plugin.go at the linked line and inspect how SpanID is appended to the trace data. Verify that the emitted value preserves the hexadecimal representation expected by Google Cloud Logging, and add or update focused plugin coverage if the repository has a suitable test.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- go, google-cloud
- Domaine
- observability-sre
- Type d'issue
- Bug
- Difficulté
- 2/5
- Temps estimé
- 1-3 heures
- Activité
- À l'abandon
- Clarté
- Clairement spécifiée
- Accessibilité débutants
- 55/100