GoogleCloudPlatform / GoogleCloudPlatform/cloud-sql-python-connector

Support hostname verification to allow `verify-full` SSL/TLS connections

Aperta
#1,087 3 commenti 0 reazioni 1 assegnatario Assegnata a @hessjcg Vedi su GitHub
priority: p1 type: feature request
Lingua principale
Python
Stelle
344
Fork
89
Merge medio
5h 33m
PR unite (30g)
2

Descrizione

### Feature Description

The Cloud SQL Python Connector currently only supports `verify-ca`
as it's highest level of [SSL/TLS client verification](https://www.postgresql.org/docs/current/libpq-ssl.html#LIBQ-SSL-CERTIFICATES).

> verify-ca: verify that the server is trustworthy by checking the certificate chain up to the root certificate

We are only getting `verify-ca` level of security due to hostname verification
being disabled currently .
https://github.com/GoogleCloudPlatform/cloud-sql-python-connector/blob/53e40c7dbec8f27e2e3e6e344bf87e08cf15c3e9/google/cloud/sql/connector/connection_info.py#L60-L61

We should support `verify-full` as it is the highest level of security.

> verify-full: will also verify that the server host name matches the name stored in the server certificate

To do so we must support hostname verification.

For Public IP and PSA Private IP connections, the server certificate's
subject CN field in the server certificate will contain the instance name
in the form `"{project}:{instance}"`. The python connector should validate
that this is correctly set during the TLS handshake. The connector should
reject the connection if this the server CN is not set correctly.

Unfortunately for PSC enabled and CAS-based instances hostname
verification is not possible. This is due to the server certificates including
the DNS name as a SAN which include a trailing dot ("."). [Python's SSL does
not allow trailing dots](https://github.com/openssl/openssl/issues/11560) during hostname verification, it requires stripping them.
This leads to `hostname mismatch` errors as the SAN is expecting a trailing dot.

See also: https://github.com/GoogleCloudPlatform/cloud-sql-jdbc-socket-factory/issues/1995

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.