GoogleCloudPlatform / GoogleCloudPlatform/cloud-sql-python-connector

Improve user agent logic

未關閉
#1,020 0 則留言 0 個 reaction 已指派 1 人 已指派給 @kgala2 在 GitHub 檢視
priority: p2 type: cleanup
主要語言
Python
星號
344
分支
89
平均合併
5 小時 33 分鐘
30 天內合併 PR
2

描述

User agent currently is set during the first connection call. Subsequent calls have no way of updating the custom user agent. Aka if you create a connector and use it with many drivers or many custom user agents only the ones used on the first connect will be set.

Instead we should keep a `set()` of user agents and add as we go and update the client.

https://github.com/GoogleCloudPlatform/cloud-sql-python-connector/blob/bb044277e58475b3c1dfc2a497935aa97c8f2e4d/google/cloud/sql/connector/connector.py#L215-L220

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。