GoogleCloudPlatform / GoogleCloudPlatform/cloud-sql-proxy
Accept loop has improper error handling, causing wrong exit code.
Aperta
priority: p3
type: bug
- Lingua principale
- Go
- Stelle
- 1.4k
- Fork
- 352
- Merge medio
- 14h 54m
- PR unite (30g)
- 5
Descrizione
When the proxy receives a SIGTERM, it will close this server socket. This can result in the server.Accept() returning a non-nil error with the message
"proxy server error: accept tcp" or "use of closed network connection". This error will be put into the error channel, causing the process end with exit code 2, instead of the appropriate 143 (TERMINATED) or 0 (SUCCESS).
See https://github.com/GoogleCloudPlatform/cloud-sql-proxy/blob/main/cmd/root.go#L1143
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.