GoogleCloudPlatform / GoogleCloudPlatform/cloud-sql-nodejs-connector

Generate or build certs during tests

Aperta
#392 0 commenti 0 reazioni 1 assegnatario Assegnata a @hessjcg Vedi su GitHub
priority: p2 type: feature request
Lingua principale
TypeScript
Stelle
97
Fork
16
Merge medio
4g 16h
PR unite (30g)
4

Descrizione

In the other Cloud SQL Connector repos (Python, Java, Go) we generate/build certs for the tests as part of the tests themselves or test infra.

Node currently has certs that were generated once and are [saved (hardcoded) for tests](https://github.com/GoogleCloudPlatform/cloud-sql-nodejs-connector/blob/4e3f31bff33cc6de8a21ff61ca1c96703bb66dd5/test/fixtures/certs.ts). This is not scalable for different cert types (CAS-based CAS for example) and requires generating new certs and updating the hardcoded values.

Instead node should generate/build certs within its test infra as the other Connector libraries do.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.