GoogleCloudPlatform / GoogleCloudPlatform/cloud-sql-nodejs-connector

Tedious sample config contains extraneous properties

Aperta
#132 1 commento 0 reazioni 1 assegnatario Assegnata a @kgala2 Vedi su GitHub
priority: p2 type: cleanup
Lingua principale
TypeScript
Stelle
97
Fork
16
Merge medio
4g 16h
PR unite (30g)
4

Descrizione

## Bug Description

In the current README sample and in `tedious` related system tests there are two properties: `server` and `port` that should not be necessary.

## Example code (or command)

These properties should not be required:

```patch
const clientOpts = await connector.getTediousOptions({
instanceConnectionName: process.env.SQLSERVER_CONNECTION_NAME,
ipType: 'PUBLIC'
});
const connection = new Connection({
- server: '0.0.0.0',
authentication: {
type: 'default',
options: {
userName: process.env.SQLSERVER_USER,
password: process.env.SQLSERVER_PASS,
},
},
options: {
...clientOpts,
- port: 9999,
database: process.env.SQLSERVER_DB,
},
})
```

#### More Info

Currently this properties are required due to a bug in the `tedious` driver itself that still tries to validate these properties even when the user is defining a custom connector factory method.

Related bug in Tedious: https://github.com/tediousjs/tedious/issues/1541

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.