GoogleCloudPlatform / GoogleCloudPlatform/cloud-profiler-java

Cannot build on arm64

Abierto
#59 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
C++
Estrellas
33
Forks
20
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Exactly same issue as described in https://github.com/GoogleCloudPlatform/cloud-profiler-java/pull/49 and https://github.com/GoogleCloudPlatform/cloud-profiler-java/issues/48

Looks like there may have been a mistake when applying the fix for this issue. Build.sh is still using || instead of && for the check.

This
```
if [[ "${MACHINE_TYPE}" != "aarch64" ]] || [[ "${MACHINE_TYPE}" != "arm64" ]]; then
```
Should instead be
```
if [[ "${MACHINE_TYPE}" != "aarch64" ]] && [[ "${MACHINE_TYPE}" != "arm64" ]]; then
```

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.