GoogleCloudPlatform / GoogleCloudPlatform/cloud-profiler-java
Cannot build on arm64
Open
- Dominant language
- C++
- Stars
- 33
- Forks
- 20
- PR merge metrics
- No merged PRs in 30d
Description
Exactly same issue as described in https://github.com/GoogleCloudPlatform/cloud-profiler-java/pull/49 and https://github.com/GoogleCloudPlatform/cloud-profiler-java/issues/48
Looks like there may have been a mistake when applying the fix for this issue. Build.sh is still using || instead of && for the check.
This
```
if [[ "${MACHINE_TYPE}" != "aarch64" ]] || [[ "${MACHINE_TYPE}" != "arm64" ]]; then
```
Should instead be
```
if [[ "${MACHINE_TYPE}" != "aarch64" ]] && [[ "${MACHINE_TYPE}" != "arm64" ]]; then
```
Contributor guide
Assessment
This issue has not been assessed yet.