GoogleCloudPlatform / GoogleCloudPlatform/cloud-opensource-java
Should ClassPathBuilder.resolve filter out irrelevant artifactproblems?
- Lingua principale
- Java
- Stelle
- 163
- Fork
- 80
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Should ClassPathBuilder.resolve filter out irrelevant artifactproblems?
https://github.com/GoogleCloudPlatform/cloud-opensource-java/pull/1210/files#r378853356
As of now, it passes the whole artifactproblems from dependencygraphbuilder to the caller. But some of the artifacts are not selected for the resolved class path. Should it filter out such artifactproblems?
```
public ClassPathResult resolve(List artifacts) {
DependencyGraphResult graphResult = DependencyGraphBuilder....
return classPathResult
}
```
```
class ClassPathResult {
private final ImmutableList classPath;
private final ImmutableListMultimap dependencyPaths;
private final ImmutableList artifactProblems;
```
# Options
## Pass all artifact problems to the caller
current implementation. The caller of `resolve` may stop processing even when the artifact problems are only for artifacts that are not selected for `classPath`
## Pass only artifact problems that is related to `classPath`
This sounds reasonable.
## Throw an exception if there is an artifact problem
Because the caller needs the artifact problems to show the error anyway, this makes the caller's code unnecessarily complex.
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.