GoogleCloudPlatform / GoogleCloudPlatform/cloud-opensource-java

Configuration file to express existing errors

Open
#1,167 3 comments 0 reactions 0 assignees View on GitHub
enhancement p3
Dominant language
Java
Stars
163
Forks
80
PR merge metrics
No merged PRs in 30d

Description

Similar to https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/940 but intended to suppress (or ignore) existing linkage errors, rather than special cases.

From Luke's comment in [BEAM-9206](https://issues.apache.org/jira/browse/BEAM-9206?focusedCommentId=17026887&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17026887):

> Typically I have seen people use an ignore list that is hardcoded somewhere such as the ones found in [spotbugs](https://github.com/apache/beam/blob/master/sdks/java/build-tools/src/main/resources/beam/spotbugs-filter.xml) and the test/tool runs and compares against that. This way the the contributor can update the existing list and get the test to pass and the reviewer can see what the edits were so the CL can "pass" all tests.

# Case of Spotbugs-filter

Beam's use case of spotbugs-filter.xml is https://github.com/apache/beam/blob/master/sdks/java/build-tools/src/main/resources/beam/spotbugs-filter.xml

```
...






...













```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.