GoogleCloudPlatform / GoogleCloudPlatform/appengine-python-standard

NDB_PY2_UNPICKLE_COMPAT?

Aperta
#103 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Python
Stelle
86
Fork
61
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

There is an env var being checked in a couple places that I don't see mentioned outside the code:
```
class PickleProperty(BlobProperty):
...
def _from_base_type(self, value):
try:
return pickle.loads(value)
except UnicodeDecodeError:
if int(os.environ.get('NDB_PY2_UNPICKLE_COMPAT', '0')):
return pickle.loads(value, encoding='bytes')
raise
```
```
class Key(object):
...
def __new__(cls, *_args, **kwargs):
...
if int(os.environ.get('NDB_PY2_UNPICKLE_COMPAT', '0')):
kwargs = {six.ensure_str(k): v for (k, v) in kwargs.items()}
```
Should we set this, is it set for us, should we avoid it?
I'm running into some assorted pickle-related issues which had me looking at [this (not-so-)recent change](https://github.com/GoogleCloudPlatform/appengine-python-standard/pull/88), and it's a bit tricky to figure out if it's better to try more "global" sorts of fixes or just site-specific workarounds to avoid dealing with messier problems.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.