hardisp static data might be a thread safety issue

Open
#136 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
cpp
Domain
backend

Research direction

Start with src/cpp/3rdparty/iers2010/hardisp/tdfrph.cpp and inspect the callers of the static cache variables. Determine whether ginan's threading design or caller-side locking makes concurrent access safe. Done means the cache's thread-safety status is established and any required change is covered by an appropriate test or documented rationale.

Written by the indexing model from the issue text.

Description

Noticed in passing that src/cpp/3rdparty/iers2010/hardisp/tdfrph.cpp is using static data for a cache that seen alone might be a thread safety issue, and I see some claims that ginan is intended to be a multi-threaded app. This may be fine, and I know little of the threading design of ginan, the callers might be ensuring this is safe by design or with locking, so please close if not an issue.

  static GTime last_epoch;
  static double d[6];
  static double dd[6];
Dominant language
C++
Stars
343
Forks
141
Avg merge
11h 51m
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from GeoscienceAustralia/ginan

All issues in GeoscienceAustralia/ginan

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.