Linter: no-else-return failing to detect return in this case

There is a bug in your linter that causes it to not recognize that the designated block can fail the if statement and skip the return statement:
1) The incorrect warning is:
“WARNING on line 75 (no-else-return)
Unnecessary 'else' after 'if'/'elif' blocks that end with 'return'”

2) The code that triggered this error is:
...
#Return false if vector_angle falls between start_arc and end_arc.
#This will ensure that weapons can only fire within their designated arcs.
if end_arc > start_arc:
if vector_angle > end_arc or vector_angle < start_arc:
return false
else:
if vector_angle > end_arc and vector_angle < start_arc:
return false

#Ensure target is within range
if vector_to_target.length() > ability_range:
return false
else:
return true

Start at the linter implementation for the no-else-return rule and reproduce the warning with the provided nested if/else snippet. Done means the rule no longer reports the final else as unnecessary when the preceding branch can continue, with regression coverage for this case.

Scritto dal modello di indicizzazione a partire dal testo della issue.